Issue 6721010: Fix bug in shader and program managers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6721010: Fix bug in shader and program managers. (Closed)

Created:
9 years, 9 months ago by greggman

Modified:
9 years, 7 months ago

Reviewers:
apatrick_chromium

CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix bug in shader and program managers. The bug was that the code would search by id instead of by pointer. This meant it was possible to free the wrong thing (ie, pass in an info with id=4 and free a different info that also happened to have id=4). This was most likely to happen when calling MarkAsDeleted since MarkAsDelete sets the id to 0. TEST=unit tests BUG=75629 R=apatrick@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79130

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+112 lines, -29 lines)			Patch
M	gpu/command_buffer/service/program_manager.h	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	gpu/command_buffer/service/program_manager.cc	View	4 chunks	+16 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/program_manager_unittest.cc	View	2 chunks	+22 lines, -1 line	0 comments	Download
M	gpu/command_buffer/service/shader_manager.h	View	3 chunks	+9 lines, -22 lines	0 comments	Download
M	gpu/command_buffer/service/shader_manager.cc	View	4 chunks	+40 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/shader_manager_unittest.cc	View	2 chunks	+21 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages