Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 672002: Reapply 97758de2adf4eb8c861b66826e890e5c3479e071. (Closed)

Created:
10 years, 9 months ago by awong
Modified:
9 years, 7 months ago
Reviewers:
albertb
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Reapply 97758de2adf4eb8c861b66826e890e5c3479e071. Original description: Create a pulseaudio upstart job that starts pulseaudio on entrance into runlevel 2. Also, setup some default client configurations. Specifically: 1) Disable autospawning by clients. upstart should spawn the only job. 2) Put the runtime dir in /var/run/pulse instead of ${HOME}/.pulse to work around HOME being reset during window manager login. 3) Put the state directory in /home/chronos/.pulse explicitly for the same reason. 4) Add a basic script for first-run volume configuration. Review URL: http://codereview.chromium.org/661389 TBR=albertb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -4 lines) Patch
M src/platform/acpi/action_hotkey.sh View 2 chunks +2 lines, -4 lines 0 comments Download
A src/platform/audioconfig/pulse/client-cros.conf View 1 chunk +9 lines, -0 lines 0 comments Download
A src/platform/audioconfig/pulse/firstrun.pa View 1 chunk +16 lines, -0 lines 0 comments Download
A src/platform/init/pulseaudio.conf View 1 chunk +48 lines, -0 lines 0 comments Download
M src/platform/init/windowmanager.conf View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
awong
10 years, 9 months ago (2010-03-08 20:29:13 UTC) #1
albertb
10 years, 9 months ago (2010-03-08 20:30:31 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698