Create pulseaudio upstart job, and add default client configurations + startup volume.

Create a pulseaudio upstart job that starts pulseaudio on entrance into runlevel 2.  Also, setup some default client configurations.  Specifically:

  1) Disable autospawning by clients.  upstart should 
     spawn the only job.
  2) Put the runtime dir in /var/run/pulse instead of 
     ${HOME}/.pulse to work around HOME being reset
     during window manager login.
  3) Put the state directory in /home/chronos/.pulse
     explicitly for the same reason.
  4) Add a basic script for first-run volume configuration.

[awong, 2010-03-02 20:28:37]

I'm in the process of testing this, but I wanted to know if you had any
immediate "NOOOO DON'T DO THISSSS" reactions to my attempt at doing a
"first-run" setup for pulseaudio.

[Chris Masone, 2010-03-02 20:33:17]

On 2010/03/02 20:28:37, awong wrote:
> I'm in the process of testing this, but I wanted to know if you had any
> immediate "NOOOO DON'T DO THISSSS" reactions to my attempt at doing a
> "first-run" setup for pulseaudio.

Ah, I think what you want here is to do the stuff in pulseaudio-firstrun.conf as
a "pre-start" script in pulseaudio.conf.  The dbus.conf upstart file has an
example of this.  You're guaranteed that a pre-start script will be called
before the body of the job is run, so it's a great place to do work like this.

[awong, 2010-03-03 03:24:52]

How's this version look?

I got rid of the amixer invocation and the post-start (there was a race
condition. :( )

[tedbo, 2010-03-03 04:19:25]

FYI

A few comments:

http://codereview.chromium.org/661389/diff/1013/1014
File src/platform/acpi/action_hotkey.sh (right):

http://codereview.chromium.org/661389/diff/1013/1014#newcode1
src/platform/acpi/action_hotkey.sh:1: #!/bin/bash
Please do not assume bash in the rootfs. I will remove bash at some point.

You may be able to replace "source /etc/pulse/pulseaudio-env.sh" with ".
/etc/pulse/pulseaudio-env.sh"

http://codereview.chromium.org/661389/diff/1013/1019
File src/platform/init/windowmanager.conf (right):

http://codereview.chromium.org/661389/diff/1013/1019#newcode22
src/platform/init/windowmanager.conf:22: env
PULSE_CLIENTCONFIG=/etc/pulse/client-cros.conf
Maybe you can add a comment about why this is needed?

[awong, 2010-03-03 18:30:08]

http://codereview.chromium.org/661389/diff/1013/1014
File src/platform/acpi/action_hotkey.sh (right):

http://codereview.chromium.org/661389/diff/1013/1014#newcode1
src/platform/acpi/action_hotkey.sh:1: #!/bin/bash
On 2010/03/03 04:19:25, tedbo wrote:
> Please do not assume bash in the rootfs. I will remove bash at some point.
> 
> You may be able to replace "source /etc/pulse/pulseaudio-env.sh" with ".
> /etc/pulse/pulseaudio-env.sh"
> 

Done.

http://codereview.chromium.org/661389/diff/1013/1019
File src/platform/init/windowmanager.conf (right):

http://codereview.chromium.org/661389/diff/1013/1019#newcode22
src/platform/init/windowmanager.conf:22: env
PULSE_CLIENTCONFIG=/etc/pulse/client-cros.conf
On 2010/03/03 04:19:25, tedbo wrote:
> Maybe you can add a comment about why this is needed?

Added a comment.

An alternate solution (and maybe a better solution) would be to replace
/etc/pulse/default.pa that gets installed by the pulseaudio emerge.  However, I
wasn't quite sure how to do that.

I know that /etc/init gets setup by customize_rootfs, but the comment in there
made it seem like this was not the ideal method.

[Chris Masone, 2010-03-03 18:35:59]

On 2010/03/03 18:30:08, awong wrote:
> http://codereview.chromium.org/661389/diff/1013/1014
> File src/platform/acpi/action_hotkey.sh (right):
> 
> http://codereview.chromium.org/661389/diff/1013/1014#newcode1
> src/platform/acpi/action_hotkey.sh:1: #!/bin/bash
> On 2010/03/03 04:19:25, tedbo wrote:
> > Please do not assume bash in the rootfs. I will remove bash at some point.
> > 
> > You may be able to replace "source /etc/pulse/pulseaudio-env.sh" with ".
> > /etc/pulse/pulseaudio-env.sh"
> > 
> 
> Done.
> 
> http://codereview.chromium.org/661389/diff/1013/1019
> File src/platform/init/windowmanager.conf (right):
> 
> http://codereview.chromium.org/661389/diff/1013/1019#newcode22
> src/platform/init/windowmanager.conf:22: env
> PULSE_CLIENTCONFIG=/etc/pulse/client-cros.conf
> On 2010/03/03 04:19:25, tedbo wrote:
> > Maybe you can add a comment about why this is needed?
> 
> Added a comment.
> 
> An alternate solution (and maybe a better solution) would be to replace
> /etc/pulse/default.pa that gets installed by the pulseaudio emerge.  However,
I
> wasn't quite sure how to do that.
> 
> I know that /etc/init gets setup by customize_rootfs, but the comment in there
> made it seem like this was not the ideal method.

Yeah, we're kind of sequestering all our ugly hacks in customize_rootfs for now.
 That way, we have them all in one place and can just work through that file and
feel confident that we've cleaned up everything.  So, if it's moar better to
replace/edit that file, I'd say do it in customize_rootfs and then we'll know
that it's a hack and we can revisit it later.

[awong, 2010-03-03 19:06:55]

On Wed, Mar 3, 2010 at 10:35 AM, <cmasone@chromium.org> wrote:

> On 2010/03/03 18:30:08, awong wrote:
>
>> http://codereview.chromium.org/661389/diff/1013/1014
>> File src/platform/acpi/action_hotkey.sh (right):
>>
>
>  http://codereview.chromium.org/661389/diff/1013/1014#newcode1
>> src/platform/acpi/action_hotkey.sh:1: #!/bin/bash
>> On 2010/03/03 04:19:25, tedbo wrote:
>> > Please do not assume bash in the rootfs. I will remove bash at some
>> point.
>> >
>> > You may be able to replace "source /etc/pulse/pulseaudio-env.sh" with ".
>> > /etc/pulse/pulseaudio-env.sh"
>> >
>>
>
>  Done.
>>
>
>  http://codereview.chromium.org/661389/diff/1013/1019
>> File src/platform/init/windowmanager.conf (right):
>>
>
>  http://codereview.chromium.org/661389/diff/1013/1019#newcode22
>> src/platform/init/windowmanager.conf:22: env
>> PULSE_CLIENTCONFIG=/etc/pulse/client-cros.conf
>> On 2010/03/03 04:19:25, tedbo wrote:
>> > Maybe you can add a comment about why this is needed?
>>
>
>  Added a comment.
>>
>
>  An alternate solution (and maybe a better solution) would be to replace
>> /etc/pulse/default.pa that gets installed by the pulseaudio emerge.
>>  However,
>>
> I
>
>> wasn't quite sure how to do that.
>>
>
>  I know that /etc/init gets setup by customize_rootfs, but the comment in
>> there
>> made it seem like this was not the ideal method.
>>
>
> Yeah, we're kind of sequestering all our ugly hacks in customize_rootfs for
> now.
>  That way, we have them all in one place and can just work through that
> file and
> feel confident that we've cleaned up everything.  So, if it's moar better
> to
> replace/edit that file, I'd say do it in customize_rootfs and then we'll
> know
> that it's a hack and we can revisit it later.


Okay. I'll migrate the hack.  That should simplify things a bit too.

[awong, 2010-03-06 02:52:48]

here's a cleaned up version of stuff.  "everything should work now."

[Chris Masone, 2010-03-06 06:41:22]

On 2010/03/06 02:52:48, awong wrote:
> here's a cleaned up version of stuff.  "everything should work now."

lgtm