PPB_CursorControl_Dev.SetCursor: Add support for custom cursor.

PPB_CursorControl_Dev.SetCursor: Add support for custom cursor.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79168

[yzshen1, 2011-03-22 06:03:01]

Hi, Brett.

I couldn't find a Mac machine to test the code for WEBKIT_USING_CG quickly. As a
result, I followed your suggestion to save that part of code for a later CL.

Please review, thanks!

[brettw, 2011-03-23 02:08:02]

LGTM

http://codereview.chromium.org/6720001/diff/3001/webkit/plugins/ppapi/ppapi_p...
File webkit/plugins/ppapi/ppapi_plugin_instance.h (right):

http://codereview.chromium.org/6720001/diff/3001/webkit/plugins/ppapi/ppapi_p...
webkit/plugins/ppapi/ppapi_plugin_instance.h:135: const PP_Point* hot_spot);
I'd pass this as a ref. We pass pointers in the C API because it doesn't have
refs. It will also allow you to remove the NULL checking.

[yzshen1, 2011-03-23 17:24:35]

http://codereview.chromium.org/6720001/diff/3001/webkit/plugins/ppapi/ppapi_p...
File webkit/plugins/ppapi/ppapi_plugin_instance.h (right):

http://codereview.chromium.org/6720001/diff/3001/webkit/plugins/ppapi/ppapi_p...
webkit/plugins/ppapi/ppapi_plugin_instance.h:135: const PP_Point* hot_spot);
On 2011/03/23 02:08:02, brettw wrote:
> I'd pass this as a ref. We pass pointers in the C API because it doesn't have
> refs. It will also allow you to remove the NULL checking.
If |type| is not PP_CURSORTYPE_CUSTOM, |hot_spot| is ignored and can be NULL. (I
have added comments.)
Using a ref will require us to create an PP_Point instance that won't be used.
If you think it is okay, I would like to leave it as it is.
Thanks!

[brettw, 2011-03-23 17:42:42]

I see, sounds fine. LGTM