PPB_CursorControl_Dev.SetCursor: Add support for custom cursor.

webkit/plugins/ppapi/ppapi_plugin_instance.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_PLUGINS_PPAPI_PPAPI_PLUGIN_INSTANCE_H_
 #define WEBKIT_PLUGINS_PPAPI_PPAPI_PLUGIN_INSTANCE_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 112 matching lines @@
   void CommitBackingTexture();
 
   // Called when the out-of-process plugin implementing this instance crashed.
   void InstanceCrashed();
 
   // PPB_Instance implementation.
   PP_Var GetWindowObject();
   PP_Var GetOwnerElementObject();
   bool BindGraphics(PP_Resource graphics_id);
   bool full_frame() const { return full_frame_; }
-  bool SetCursor(PP_CursorType_Dev type);
+  bool SetCursor(PP_CursorType_Dev type,
+                 PP_Resource custom_image,
+                 const PP_Point* hot_spot);

[brettw, 2011/03/23 02:08:02]

I'd pass this as a ref. We pass pointers in the C API because it doesn't have
refs. It will also allow you to remove the NULL checking.

[yzshen1, 2011/03/23 17:24:35]

If |type| is not PP_CURSORTYPE_CUSTOM, |hot_spot| is ignored and can be NULL. (I
have added comments.)
Using a ref will require us to create an PP_Point instance that won't be used.
If you think it is okay, I would like to leave it as it is.
Thanks!

   PP_Var ExecuteScript(PP_Var script, PP_Var* exception);
 
   // PPP_Instance pass-through.
   void Delete();
   bool Initialize(WebKit::WebPluginContainer* container,
                   const std::vector<std::string>& arg_names,
                   const std::vector<std::string>& arg_values,
                   bool full_frame);
   bool HandleDocumentLoad(PPB_URLLoader_Impl* loader);
   bool HandleInputEvent(const WebKit::WebInputEvent& event,
@@ skipping 227 matching lines @@
   typedef std::map<NPObject*, ObjectVar*> NPObjectToObjectVarMap;
   NPObjectToObjectVarMap np_object_to_object_var_;
 
   DISALLOW_COPY_AND_ASSIGN(PluginInstance);
 };
 
 }  // namespace ppapi
 }  // namespace webkit
 
 #endif  // WEBKIT_PLUGINS_PPAPI_PPAPI_PLUGIN_INSTANCE_H_