Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 67197: Start addressing massive arrays on the stack. There is hardly ever... (Closed)

Created:
11 years, 8 months ago by iposva
Modified:
9 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Start addressing massive arrays on the stack. There is hardly ever a reason to stack allocate large chunks of stack space. - Runtime_GetCFrames used to allocate a frame size of 52040 bytes. - PreallocatedMemoryThread::Run used to allocate 32784 bytes. - Fixed StringStream overflow conditions. Committed: http://code.google.com/p/v8/source/detail?r=1729

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -25 lines) Patch
M src/platform.h View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-freebsd.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/platform-linux.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/platform-macos.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/platform-nullos.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-win32.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M src/runtime.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/string-stream.h View 1 chunk +1 line, -1 line 0 comments Download
M src/string-stream.cc View 3 chunks +18 lines, -14 lines 0 comments Download
M src/top.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/utils.h View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
iposva
11 years, 8 months ago (2009-04-16 00:58:33 UTC) #1
Mikhail Naganov
http://codereview.chromium.org/67197/diff/1/4 File src/runtime.cc (right): http://codereview.chromium.org/67197/diff/1/4#newcode5934 Line 5934: frames.Dispose(); I think we should use a stack-allocated ...
11 years, 8 months ago (2009-04-16 01:20:54 UTC) #2
Søren Thygesen Gjesse
LGTM
11 years, 8 months ago (2009-04-16 05:25:44 UTC) #3
iposva
Addressed review comments (added ScopedVector) and fixed StringStream overflow conditions. Please take another look. -Ivan
11 years, 8 months ago (2009-04-16 17:39:05 UTC) #4
Mikhail Naganov
11 years, 8 months ago (2009-04-16 17:41:41 UTC) #5
LGTM

Cool, thanks!

Please fix lint errors prior to submitting.

Powered by Google App Engine
This is Rietveld 408576698