src/top.cc - Issue 67197: Start addressing massive arrays on the stack. There is hardly ever...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/top.cc

Issue 67197: Start addressing massive arrays on the stack. There is hardly ever... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 11 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/top.cc

===================================================================

--- src/top.cc (revision 1718)

+++ src/top.cc (working copy)

@@ -116,7 +116,7 @@

// When the thread starts running it will allocate a fixed number of bytes

// on the stack and publish the location of this memory for others to use.

void Run() {

- EmbeddedVector<char, 32 * 1024> local_buffer;

+ EmbeddedVector<char, 15 * 1024> local_buffer;

// Initialize the buffer with a known good value.

OS::StrNCpy(local_buffer, "Trace data was not generated.\n",

« no previous file with comments | « src/string-stream.cc ('k') | src/utils.h » ('j') | no next file with comments »