Issue 6719025: graphics_o3dselenium: change all return error.* to raise error.*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6719025: graphics_o3dselenium: change all return error.* to raise error.* (Closed)

Created:
9 years, 9 months ago by zbehan

Modified:
9 years, 7 months ago

Reviewers:
Zhenyao Mo

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli

Base URL:
ssh://git@gitrw.chromium.org:9222/autotest.git@master

Visibility:
Public.

Description

graphics_o3dselenium: change all return error.* to raise error.* The former is a wrong way to do it and in fact doesn't do anything. BUG=none TEST=run it Change-Id: I583aee7afa55a299576bb5652ac61fab5b6fd351 R=zmo@chromium.org Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a87e311

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	client/site_tests/graphics_O3DSelenium/graphics_O3DSelenium.py	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Zhenyao Mo

9 years, 9 months ago (2011-03-27 23:57:09 UTC) #2

LGTM

On Sun, Mar 27, 2011 at 3:44 AM,  <zbehan@chromium.org> wrote:
> Reviewers: Zhenyao Mo,
>
> Description:
> graphics_o3dselenium: change all return error.* to raise error.*
>
> The former is a wrong way to do it and in fact doesn't do anything.
>
> BUG=none
> TEST=run it
>
> Change-Id: I583aee7afa55a299576bb5652ac61fab5b6fd351
>
> R=zmo@chromium.org
>
>
> Please review this at http://codereview.chromium.org/6719025/
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/autotest.git@master
>
> Affected files:
>  M client/site_tests/graphics_O3DSelenium/graphics_O3DSelenium.py
>
>
> Index: client/site_tests/graphics_O3DSelenium/graphics_O3DSelenium.py
> diff --git a/client/site_tests/graphics_O3DSelenium/graphics_O3DSelenium.py
> b/client/site_tests/graphics_O3DSelenium/graphics_O3DSelenium.py
> index
>
4c99289785a8b2ae0b575c238d41a44057f3187b..f88a4d9a165b46c452ce4815e789ebf167a56dd3
> 100644
> --- a/client/site_tests/graphics_O3DSelenium/graphics_O3DSelenium.py
> +++ b/client/site_tests/graphics_O3DSelenium/graphics_O3DSelenium.py
> @@ -68,16 +68,16 @@ class graphics_O3DSelenium(cros_ui_test.UITest):
>         # Find out total tests.
>         report = re.findall(r"([0-9]+) tests run.", result.stdout)
>         if not report:
> -            return error.TestFail('Output missing: total test number
> unknown!')
> +            raise error.TestFail('Output missing: total test number
> unknown!')
>         total = int(report[-1])
>         # Find out failures.
>         report = re.findall(r"([0-9]+) errors.", result.stdout)
>         if not report:
> -            return error.TestFail('Output missing: error number unknown!')
> +            raise error.TestFail('Output missing: error number unknown!')
>         failures = int(report[-1])
>         report = re.findall(r"([0-9]+) failures.", result.stdout)
>         if not report:
> -            return error.TestFail('Output missing: failure number
> unknown!')
> +            raise error.TestFail('Output missing: failure number unknown!')
>         failures += int(report[-1])
>         logging.info('RESULTS: %d out of %d tests failed!', failures, total)
>
>
>
>

Expand Messages | Collapse Messages