graphics_o3dselenium: change all return error.* to raise error.*

client/site_tests/graphics_O3DSelenium/graphics_O3DSelenium.py

 # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging, os, re, shutil
 from autotest_lib.client.bin import utils
 from autotest_lib.client.common_lib import error
 from autotest_lib.client.cros import cros_ui, cros_ui_test
 
 class graphics_O3DSelenium(cros_ui_test.UITest):
@@ skipping 50 matching lines @@
         cmd = cmd + " --browserpath=../../chrome_wrapper"
         cmd = cmd + " --browser=*googlechrome"
         cmd = cmd + " --screenshotsdir=tests/selenium/screenshots_chrome"
         cmd = cmd + " --java=/usr/local/lib/icedtea6/bin/java"
         cmd = cros_ui.xcommand(cmd)
         result = utils.run(cmd, ignore_status = True)
 
         # Find out total tests.
         report = re.findall(r"([0-9]+) tests run.", result.stdout)
         if not report:
-            return error.TestFail('Output missing: total test number unknown!')
+            raise error.TestFail('Output missing: total test number unknown!')
         total = int(report[-1])
         # Find out failures.
         report = re.findall(r"([0-9]+) errors.", result.stdout)
         if not report:
-            return error.TestFail('Output missing: error number unknown!')
+            raise error.TestFail('Output missing: error number unknown!')
         failures = int(report[-1])
         report = re.findall(r"([0-9]+) failures.", result.stdout)
         if not report:
-            return error.TestFail('Output missing: failure number unknown!')
+            raise error.TestFail('Output missing: failure number unknown!')
         failures += int(report[-1])
         logging.info('RESULTS: %d out of %d tests failed!', failures, total)
 
         # If all failed cases belong to flaky_test_list, we still pass the test.
         report = re.findall(r"SELENIUMRESULT ([a-zA-Z_0-9]+) "
                             r"\([a-zA-Z_0-9]+\.[a-zA-Z_0-9]+\) "
                             r"<\*googlechrome> \[[0-9.s]+\]: FAIL",
                             result.stdout)
         ignored_failures = 0
         error_message = "Unexpected failure cases:"
         for report_item in report:
             if report_item in self.flaky_test_list:
                 ignored_failures += 1
                 logging.info("FAILURE (ignored): %s" % report_item)
             else:
                 error_message += " " + report_item
 
         if failures > ignored_failures:
             raise error.TestFail(error_message)