Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Unified Diff: tests/owners_unittest.py

Issue 6717004: add test with an OWNERS file that has names plus a wildcard (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/owners_unittest.py
diff --git a/tests/owners_unittest.py b/tests/owners_unittest.py
index de24a7b7cd50658b19a44bfd746ecd772d9fe7cb..1ac7a5e20235f41f70f1c8ce5ad5ec65513cc2df 100755
--- a/tests/owners_unittest.py
+++ b/tests/owners_unittest.py
@@ -39,6 +39,8 @@ def test_repo():
'/chrome/renderer/safe_browsing/scorer.h': '',
'/content/OWNERS': owners_file(john, darin, comment='foo', noparent=True),
'/content/content.gyp': '',
+ '/content/views/OWNERS': owners_file(ben, john, owners.EVERYONE,
+ noparent=True),
})
@@ -70,6 +72,10 @@ class OwnersDatabaseTest(unittest.TestCase):
self.assert_covered_by(['content/content.gyp'], [john])
self.assert_covered_by(['chrome/gpu/OWNERS'], [ken])
+ def test_covered_by__owners_plus_everyone(self):
+ self.assert_covered_by(['/content/views/OWNERS'], [ben])
+ self.assert_covered_by(['/content/views/OWNERS'], [ken])
+
def test_covered_by__owners_propagates_down(self):
self.assert_covered_by(['chrome/gpu/OWNERS'], [ben])
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698