Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Side by Side Diff: tests/owners_unittest.py

Issue 6717004: add test with an OWNERS file that has names plus a wildcard (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Unit tests for owners.py.""" 6 """Unit tests for owners.py."""
7 7
8 import unittest 8 import unittest
9 9
10 import owners 10 import owners
(...skipping 21 matching lines...) Expand all
32 '/OWNERS': owners_file(owners.EVERYONE), 32 '/OWNERS': owners_file(owners.EVERYONE),
33 '/base/vlog.h': '', 33 '/base/vlog.h': '',
34 '/chrome/OWNERS': owners_file(ben, brett), 34 '/chrome/OWNERS': owners_file(ben, brett),
35 '/chrome/gpu/OWNERS': owners_file(ken), 35 '/chrome/gpu/OWNERS': owners_file(ken),
36 '/chrome/gpu/gpu_channel.h': '', 36 '/chrome/gpu/gpu_channel.h': '',
37 '/chrome/renderer/OWNERS': owners_file(peter), 37 '/chrome/renderer/OWNERS': owners_file(peter),
38 '/chrome/renderer/gpu/gpu_channel_host.h': '', 38 '/chrome/renderer/gpu/gpu_channel_host.h': '',
39 '/chrome/renderer/safe_browsing/scorer.h': '', 39 '/chrome/renderer/safe_browsing/scorer.h': '',
40 '/content/OWNERS': owners_file(john, darin, comment='foo', noparent=True), 40 '/content/OWNERS': owners_file(john, darin, comment='foo', noparent=True),
41 '/content/content.gyp': '', 41 '/content/content.gyp': '',
42 '/content/views/OWNERS': owners_file(ben, john, owners.EVERYONE,
43 noparent=True),
42 }) 44 })
43 45
44 46
45 class OwnersDatabaseTest(unittest.TestCase): 47 class OwnersDatabaseTest(unittest.TestCase):
46 def setUp(self): 48 def setUp(self):
47 self.repo = test_repo() 49 self.repo = test_repo()
48 self.files = self.repo.files 50 self.files = self.repo.files
49 self.root = '/' 51 self.root = '/'
50 self.fopen = self.repo.open_for_reading 52 self.fopen = self.repo.open_for_reading
51 53
(...skipping 11 matching lines...) Expand all
63 self.assertTrue(db.files_are_covered_by(set(files), set(reviewers))) 65 self.assertTrue(db.files_are_covered_by(set(files), set(reviewers)))
64 66
65 def test_covered_by__everyone(self): 67 def test_covered_by__everyone(self):
66 self.assert_covered_by(['DEPS'], [john]) 68 self.assert_covered_by(['DEPS'], [john])
67 self.assert_covered_by(['DEPS'], [darin]) 69 self.assert_covered_by(['DEPS'], [darin])
68 70
69 def test_covered_by__explicit(self): 71 def test_covered_by__explicit(self):
70 self.assert_covered_by(['content/content.gyp'], [john]) 72 self.assert_covered_by(['content/content.gyp'], [john])
71 self.assert_covered_by(['chrome/gpu/OWNERS'], [ken]) 73 self.assert_covered_by(['chrome/gpu/OWNERS'], [ken])
72 74
75 def test_covered_by__owners_plus_everyone(self):
76 self.assert_covered_by(['/content/views/OWNERS'], [ben])
77 self.assert_covered_by(['/content/views/OWNERS'], [ken])
78
73 def test_covered_by__owners_propagates_down(self): 79 def test_covered_by__owners_propagates_down(self):
74 self.assert_covered_by(['chrome/gpu/OWNERS'], [ben]) 80 self.assert_covered_by(['chrome/gpu/OWNERS'], [ben])
75 81
76 def test_covered_by__no_file_in_dir(self): 82 def test_covered_by__no_file_in_dir(self):
77 self.assert_covered_by(['/chrome/renderer/gpu/gpu_channel_host.h'], [peter]) 83 self.assert_covered_by(['/chrome/renderer/gpu/gpu_channel_host.h'], [peter])
78 84
79 def assert_not_covered_by(self, files, reviewers, unreviewed_files): 85 def assert_not_covered_by(self, files, reviewers, unreviewed_files):
80 db = self.db() 86 db = self.db()
81 self.assertEquals(db.files_not_covered_by(set(files), set(reviewers)), 87 self.assertEquals(db.files_not_covered_by(set(files), set(reviewers)),
82 set(unreviewed_files)) 88 set(unreviewed_files))
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 163
158 def test_syntax_error__unknown_set(self): 164 def test_syntax_error__unknown_set(self):
159 self.assert_syntax_error('set myfatherisbillgates\n') 165 self.assert_syntax_error('set myfatherisbillgates\n')
160 166
161 def test_syntax_error__bad_email(self): 167 def test_syntax_error__bad_email(self):
162 self.assert_syntax_error('ben\n') 168 self.assert_syntax_error('ben\n')
163 169
164 170
165 if __name__ == '__main__': 171 if __name__ == '__main__':
166 unittest.main() 172 unittest.main()
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698