chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.h ('k') | chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_ui.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.h

diff --git a/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.h b/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.h

index 33f8fc41d83254b2ca9416fb162fc9992ac30f79..22b0cdbe59bcb70b5fa62ccc230d5251ccab6c16 100644

--- a/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.h

+++ b/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.h

@@ -26,24 +26,23 @@ class SyncFileSystemInternalsHandler

public sync_file_system::TaskLogger::Observer {

public:

explicit SyncFileSystemInternalsHandler(Profile* profile);

- virtual ~SyncFileSystemInternalsHandler();

+ ~SyncFileSystemInternalsHandler() override;

// content::WebUIMessageHandler implementation.

- virtual void RegisterMessages() override;

+ void RegisterMessages() override;

// sync_file_system::SyncEventObserver interface implementation.

- virtual void OnSyncStateUpdated(

- const GURL& app_origin,

- sync_file_system::SyncServiceState state,

- const std::string& description) override;

- virtual void OnFileSynced(const storage::FileSystemURL& url,

- sync_file_system::SyncFileType file_type,

- sync_file_system::SyncFileStatus status,

- sync_file_system::SyncAction action,

- sync_file_system::SyncDirection direction) override;

+ void OnSyncStateUpdated(const GURL& app_origin,

+ sync_file_system::SyncServiceState state,

+ const std::string& description) override;

+ void OnFileSynced(const storage::FileSystemURL& url,

+ sync_file_system::SyncFileType file_type,

+ sync_file_system::SyncFileStatus status,

+ sync_file_system::SyncAction action,

+ sync_file_system::SyncDirection direction) override;

// sync_file_system::TaskLogger::Observer implementation.

- virtual void OnLogRecorded(

+ void OnLogRecorded(

const sync_file_system::TaskLogger::TaskLog& task_log) override;

private: