chrome/browser/ui/zoom/zoom_controller.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/zoom/zoom_controller.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/window_sizer/window_sizer_common_unittest.cc ('k') | chrome/browser/ui/zoom/zoom_controller_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/zoom/zoom_controller.h

diff --git a/chrome/browser/ui/zoom/zoom_controller.h b/chrome/browser/ui/zoom/zoom_controller.h

index a6bcb7aabf73542fb15295eebc66dc3083ae851b..db771ee3084c55d718fca57d49765f572a7d05a8 100644

--- a/chrome/browser/ui/zoom/zoom_controller.h

+++ b/chrome/browser/ui/zoom/zoom_controller.h

@@ -66,7 +66,7 @@ class ZoomController : public content::WebContentsObserver,

bool can_show_bubble;

};

- virtual ~ZoomController();

+ ~ZoomController() override;

ZoomMode zoom_mode() const { return zoom_mode_; }

@@ -121,10 +121,10 @@ class ZoomController : public content::WebContentsObserver,

void SetZoomMode(ZoomMode zoom_mode);

// content::WebContentsObserver overrides:

- virtual void DidNavigateMainFrame(

+ void DidNavigateMainFrame(

const content::LoadCommittedDetails& details,

const content::FrameNavigateParams& params) override;

- virtual void WebContentsDestroyed() override;

+ void WebContentsDestroyed() override;

protected:

// Protected for testing.