chrome/browser/ui/cocoa/location_bar/bubble_decoration.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/bubble_decoration.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/cocoa/keystone_infobar_delegate.mm ('k') | chrome/browser/ui/cocoa/location_bar/button_decoration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/location_bar/bubble_decoration.h

diff --git a/chrome/browser/ui/cocoa/location_bar/bubble_decoration.h b/chrome/browser/ui/cocoa/location_bar/bubble_decoration.h

index 4a290c5a4a0dfc515142f9dc2e3e6c047aa21387..25b5bd8f70a32e6c3d6a886c5e6f8b8d8b94f712 100644

--- a/chrome/browser/ui/cocoa/location_bar/bubble_decoration.h

+++ b/chrome/browser/ui/cocoa/location_bar/bubble_decoration.h

@@ -18,7 +18,7 @@

class BubbleDecoration : public LocationBarDecoration {

public:

BubbleDecoration();

- virtual ~BubbleDecoration();

+ ~BubbleDecoration() override;

// Setup the drawing parameters.

NSImage* GetImage();

@@ -28,11 +28,11 @@ class BubbleDecoration : public LocationBarDecoration {

virtual ui::NinePartImageIds GetBubbleImageIds() = 0;

// Implement |LocationBarDecoration|.

- virtual void DrawInFrame(NSRect frame, NSView* control_view) override;

- virtual void DrawWithBackgroundInFrame(NSRect background_frame,

- NSRect frame,

- NSView* control_view) override;

- virtual CGFloat GetWidthForSpace(CGFloat width) override;

+ void DrawInFrame(NSRect frame, NSView* control_view) override;

+ void DrawWithBackgroundInFrame(NSRect background_frame,

+ NSRect frame,

+ NSView* control_view) override;

+ CGFloat GetWidthForSpace(CGFloat width) override;

protected:

// Helper returning bubble width for the given |image| and |label|