chrome/browser/ui/cocoa/panels/display_settings_provider_cocoa.mm - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/panels/display_settings_provider_cocoa.mm

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/cocoa/one_click_signin_dialog_controller_browsertest.mm ('k') | chrome/browser/ui/cocoa/panels/panel_cocoa.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/panels/display_settings_provider_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/panels/display_settings_provider_cocoa.mm b/chrome/browser/ui/cocoa/panels/display_settings_provider_cocoa.mm

index 9a187bf9ecf625448c16a50718e12b7adbacbbd5..88cd8fd9c005886729539400d6b7c777dbb1240a 100644

--- a/chrome/browser/ui/cocoa/panels/display_settings_provider_cocoa.mm

+++ b/chrome/browser/ui/cocoa/panels/display_settings_provider_cocoa.mm

@@ -30,22 +30,22 @@ class DisplaySettingsProviderCocoa : public DisplaySettingsProvider,

public content::NotificationObserver {

public:

DisplaySettingsProviderCocoa();

- virtual ~DisplaySettingsProviderCocoa();

+ ~DisplaySettingsProviderCocoa() override;

void ActiveSpaceChanged();

protected:

// Overridden from DisplaySettingsProvider:

- virtual bool NeedsPeriodicFullScreenCheck() const override;

- virtual bool IsFullScreen() override;

+ bool NeedsPeriodicFullScreenCheck() const override;

+ bool IsFullScreen() override;

// Overridden from ui::WorkAreaWatcherObserver:

- virtual void WorkAreaChanged() override;

+ void WorkAreaChanged() override;

// Overridden from content::NotificationObserver:

- virtual void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override;

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override;

private:

void ActiveWorkSpaceChanged();