chrome/browser/ui/hung_plugin_tab_helper.cc - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/hung_plugin_tab_helper.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/hung_plugin_tab_helper.h ('k') | chrome/browser/ui/location_bar/location_bar_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/hung_plugin_tab_helper.cc

diff --git a/chrome/browser/ui/hung_plugin_tab_helper.cc b/chrome/browser/ui/hung_plugin_tab_helper.cc

index 34027262df3d58d8e74c8efa8ad447998972f53c..1b6d092ea1ee7b8bb76ddf2a451fbc74d4e79c89 100644

--- a/chrome/browser/ui/hung_plugin_tab_helper.cc

+++ b/chrome/browser/ui/hung_plugin_tab_helper.cc

@@ -140,14 +140,14 @@ class HungPluginInfoBarDelegate : public ConfirmInfoBarDelegate {

HungPluginInfoBarDelegate(HungPluginTabHelper* helper,

int plugin_child_id,

const base::string16& plugin_name);

- virtual ~HungPluginInfoBarDelegate();

+ ~HungPluginInfoBarDelegate() override;

// ConfirmInfoBarDelegate:

- virtual int GetIconID() const override;

- virtual base::string16 GetMessageText() const override;

- virtual int GetButtons() const override;

- virtual base::string16 GetButtonLabel(InfoBarButton button) const override;

- virtual bool Accept() override;

+ int GetIconID() const override;

+ base::string16 GetMessageText() const override;

+ int GetButtons() const override;

+ base::string16 GetButtonLabel(InfoBarButton button) const override;

+ bool Accept() override;

HungPluginTabHelper* helper_;

int plugin_child_id_;