chrome/browser/ui/webui/ntp/ntp_resource_cache.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/ntp_resource_cache.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/webui/ntp/ntp_login_handler.h ('k') | chrome/browser/ui/webui/ntp/ntp_resource_cache_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/ntp/ntp_resource_cache.h

diff --git a/chrome/browser/ui/webui/ntp/ntp_resource_cache.h b/chrome/browser/ui/webui/ntp/ntp_resource_cache.h

index 7b6e37014badb3737e3bd028e4c9a3985e6c7093..749e0a945f471c2cb74b84fd72ba5795962b53b6 100644

--- a/chrome/browser/ui/webui/ntp/ntp_resource_cache.h

+++ b/chrome/browser/ui/webui/ntp/ntp_resource_cache.h

@@ -36,7 +36,7 @@ class NTPResourceCache : public content::NotificationObserver,

};

explicit NTPResourceCache(Profile* profile);

- virtual ~NTPResourceCache();

+ ~NTPResourceCache() override;

base::RefCountedMemory* GetNewTabHTML(WindowType win_type);

base::RefCountedMemory* GetNewTabCSS(WindowType win_type);

@@ -55,9 +55,9 @@ class NTPResourceCache : public content::NotificationObserver,

should_show_recently_closed_menu_ = should_show_recently_closed_menu;

}

// content::NotificationObserver interface.

- virtual void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override;

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override;

static WindowType GetWindowType(

Profile* profile, content::RenderProcessHost* render_host);