chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/app_list/test/test_app_list_controller_delegate.h ('k') | chrome/browser/ui/app_modal_dialogs/javascript_dialog_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.h

diff --git a/chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.h b/chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.h

index 01b3aa5edca3205ef0d31194121819e9b9cfd57f..87dd203e7ba5cf5c35f501928c9dbedf69dc1896 100644

--- a/chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.h

+++ b/chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.h

@@ -42,12 +42,12 @@ class JavaScriptAppModalDialog : public AppModalDialog {

bool is_before_unload_dialog,

bool is_reload,

const content::JavaScriptDialogManager::DialogClosedCallback& callback);

- virtual ~JavaScriptAppModalDialog();

+ ~JavaScriptAppModalDialog() override;

// Overridden from AppModalDialog:

- virtual NativeAppModalDialog* CreateNativeDialog() override;

- virtual bool IsJavaScriptModalDialog() override;

- virtual void Invalidate() override;

+ NativeAppModalDialog* CreateNativeDialog() override;

+ bool IsJavaScriptModalDialog() override;

+ void Invalidate() override;

// Callbacks from NativeDialog when the user accepts or cancels the dialog.

void OnCancel(bool suppress_js_messages);