Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3108)

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h
diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h
index 5d5ac0289e3b5222fe38a794f5994c19849321fb..1c833c47e943f807e24690bdb53cd2c39d73cebc 100644
--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h
+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h
@@ -28,25 +28,23 @@ class OmniboxPopupViewMac : public OmniboxPopupView,
OmniboxPopupViewMac(OmniboxView* omnibox_view,
OmniboxEditModel* edit_model,
NSTextField* field);
- virtual ~OmniboxPopupViewMac();
+ ~OmniboxPopupViewMac() override;
// Overridden from OmniboxPopupView:
- virtual bool IsOpen() const override;
- virtual void InvalidateLine(size_t line) override {}
- virtual void UpdatePopupAppearance() override;
- virtual gfx::Rect GetTargetBounds() override;
+ bool IsOpen() const override;
+ void InvalidateLine(size_t line) override {}
+ void UpdatePopupAppearance() override;
+ gfx::Rect GetTargetBounds() override;
// This is only called by model in SetSelectedLine() after updating
// everything. Popup should already be visible.
- virtual void PaintUpdatesNow() override;
- virtual void OnDragCanceled() override {}
+ void PaintUpdatesNow() override;
+ void OnDragCanceled() override {}
// Overridden from OmniboxPopupMatrixDelegate:
- virtual void OnMatrixRowSelected(OmniboxPopupMatrix* matrix,
- size_t row) override;
- virtual void OnMatrixRowClicked(OmniboxPopupMatrix* matrix,
- size_t row) override;
- virtual void OnMatrixRowMiddleClicked(OmniboxPopupMatrix* matrix,
- size_t row) override;
+ void OnMatrixRowSelected(OmniboxPopupMatrix* matrix, size_t row) override;
+ void OnMatrixRowClicked(OmniboxPopupMatrix* matrix, size_t row) override;
+ void OnMatrixRowMiddleClicked(OmniboxPopupMatrix* matrix,
+ size_t row) override;
OmniboxPopupMatrix* matrix() { return matrix_; }

Powered by Google App Engine
This is Rietveld 408576698