chrome/browser/ui/webui/chrome_url_data_manager_browsertest.cc - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chrome_url_data_manager_browsertest.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/webui/bookmarks_ui.h ('k') | chrome/browser/ui/webui/chrome_web_contents_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/chrome_url_data_manager_browsertest.cc

diff --git a/chrome/browser/ui/webui/chrome_url_data_manager_browsertest.cc b/chrome/browser/ui/webui/chrome_url_data_manager_browsertest.cc

index b5951e4fbbb39371120ad301c69db22baf269069..8feb0e496d2664d96733869d9b894d4f8094ffd8 100644

--- a/chrome/browser/ui/webui/chrome_url_data_manager_browsertest.cc

+++ b/chrome/browser/ui/webui/chrome_url_data_manager_browsertest.cc

@@ -22,9 +22,9 @@ class NavigationNotificationObserver : public content::NotificationObserver {

content::NotificationService::AllSources());

}

- virtual void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override {

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override {

DCHECK_EQ(content::NOTIFICATION_NAV_ENTRY_COMMITTED, type);

got_navigation_ = true;

http_status_code_ =