chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/cocoa/screen_capture_notification_ui_cocoa.h ('k') | chrome/browser/ui/cocoa/status_bubble_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm

index ff46f9c14060819a315b567f48fdab32a0ed448f..9d471b923de6fe2903f327656efcdfd7df25dc2e 100644

--- a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm

+++ b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm

@@ -49,13 +49,12 @@ class SSLClientAuthObserverCocoaBridge : public SSLClientAuthObserver,

}

// SSLClientAuthObserver implementation:

- virtual void OnCertSelectedByNotification() override {

+ void OnCertSelectedByNotification() override {

[controller_ closeWebContentsModalDialog];

}

// ConstrainedWindowMacDelegate implementation:

- virtual void OnConstrainedWindowClosed(

- ConstrainedWindowMac* window) override {

+ void OnConstrainedWindowClosed(ConstrainedWindowMac* window) override {

// |onConstrainedWindowClosed| will delete the sheet which might be still

// in use higher up the call stack. Wait for the next cycle of the event

// loop to call this function.