Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7651)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
index ef9ed539ed77729bd7f3ed923979f47c77371252..7482d5ad00ec461e67bb5e8583355090110d29cb 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
@@ -29,7 +29,7 @@ class ManagePasswordsUIController
public content::WebContentsUserData<ManagePasswordsUIController>,
public password_manager::PasswordStore::Observer {
public:
- virtual ~ManagePasswordsUIController();
+ ~ManagePasswordsUIController() override;
// Called when the user submits a form containing login information, so we
// can handle later requests to save or blacklist that login information.
@@ -56,7 +56,7 @@ class ManagePasswordsUIController
const autofill::PasswordFormMap& password_form_map);
// PasswordStore::Observer implementation.
- virtual void OnLoginsChanged(
+ void OnLoginsChanged(
const password_manager::PasswordStoreChangeList& changes) override;
// Called from the model when the user chooses to save a password; passes the
@@ -105,10 +105,10 @@ class ManagePasswordsUIController
virtual void NeverSavePasswordInternal();
// content::WebContentsObserver:
- virtual void DidNavigateMainFrame(
+ void DidNavigateMainFrame(
const content::LoadCommittedDetails& details,
const content::FrameNavigateParams& params) override;
- virtual void WasHidden() override;
+ void WasHidden() override;
// We create copies of PasswordForm objects that come in with unclear lifetime
// and store them in this vector as well as in |password_form_map_| to ensure
@@ -143,7 +143,7 @@ class ManagePasswordsUIController
void UpdateBubbleAndIconVisibility();
// content::WebContentsObserver:
- virtual void WebContentsDestroyed() override;
+ void WebContentsDestroyed() override;
// Set by OnPasswordSubmitted() when the user submits a form containing login
// information. If the user responds to a subsequent "Do you want to save

Powered by Google App Engine
This is Rietveld 408576698