Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Unified Diff: chrome/browser/ui/app_list/app_list_service_impl.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/app_list_service_impl.h
diff --git a/chrome/browser/ui/app_list/app_list_service_impl.h b/chrome/browser/ui/app_list/app_list_service_impl.h
index e87a9335ce461d1290247fd4709e306d039bb5ff..c9fd6668f3b1a0b1d737fcc2961f5c4670dec6c5 100644
--- a/chrome/browser/ui/app_list/app_list_service_impl.h
+++ b/chrome/browser/ui/app_list/app_list_service_impl.h
@@ -32,7 +32,7 @@ class AppListServiceImplTestApi;
class AppListServiceImpl : public AppListService,
public ProfileInfoCacheObserver {
public:
- virtual ~AppListServiceImpl();
+ ~AppListServiceImpl() override;
// Constructor used for testing.
AppListServiceImpl(const base::CommandLine& command_line,
@@ -47,20 +47,19 @@ class AppListServiceImpl : public AppListService,
static void RecordAppListAppLaunch();
// AppListService overrides:
- virtual void SetAppListNextPaintCallback(void (*callback)()) override;
- virtual void HandleFirstRun() override;
- virtual void Init(Profile* initial_profile) override;
- virtual base::FilePath GetProfilePath(
- const base::FilePath& user_data_dir) override;
- virtual void SetProfilePath(const base::FilePath& profile_path) override;
- virtual void Show() override;
- virtual void ShowForVoiceSearch(Profile* profile) override;
- virtual void ShowForAppInstall(Profile* profile,
- const std::string& extension_id,
- bool start_discovery_tracking) override;
- virtual void EnableAppList(Profile* initial_profile,
- AppListEnableSource enable_source) override;
- virtual void CreateShortcut() override;
+ void SetAppListNextPaintCallback(void (*callback)()) override;
+ void HandleFirstRun() override;
+ void Init(Profile* initial_profile) override;
+ base::FilePath GetProfilePath(const base::FilePath& user_data_dir) override;
+ void SetProfilePath(const base::FilePath& profile_path) override;
+ void Show() override;
+ void ShowForVoiceSearch(Profile* profile) override;
+ void ShowForAppInstall(Profile* profile,
+ const std::string& extension_id,
+ bool start_discovery_tracking) override;
+ void EnableAppList(Profile* initial_profile,
+ AppListEnableSource enable_source) override;
+ void CreateShortcut() override;
protected:
AppListServiceImpl();
@@ -94,8 +93,7 @@ class AppListServiceImpl : public AppListService,
Profile::CreateStatus status);
// ProfileInfoCacheObserver overrides:
- virtual void OnProfileWillBeRemoved(
- const base::FilePath& profile_path) override;
+ void OnProfileWillBeRemoved(const base::FilePath& profile_path) override;
scoped_ptr<ProfileStore> profile_store_;
base::CommandLine command_line_;

Powered by Google App Engine
This is Rietveld 408576698