Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc b/chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc
index a87ce3c34040f804ced5e53b34e16ebdd460c723..e39fe72ce0c5da794ffbc9eb760b985f8e9069f7 100644
--- a/chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc
+++ b/chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc
@@ -43,7 +43,7 @@ class MockWebContentsObserver : public content::WebContentsObserver {
class OneClickTestProfileSyncService : public TestProfileSyncService {
public:
- virtual ~OneClickTestProfileSyncService() {}
+ ~OneClickTestProfileSyncService() override {}
// Helper routine to be used in conjunction with
// BrowserContextKeyedServiceFactory::SetTestingFactory().
@@ -51,11 +51,11 @@ class OneClickTestProfileSyncService : public TestProfileSyncService {
return new OneClickTestProfileSyncService(static_cast<Profile*>(profile));
}
- virtual bool FirstSetupInProgress() const override {
+ bool FirstSetupInProgress() const override {
return first_setup_in_progress_;
}
- virtual bool SyncActive() const override { return sync_active_; }
+ bool SyncActive() const override { return sync_active_; }
void set_first_setup_in_progress(bool in_progress) {
first_setup_in_progress_ = in_progress;
@@ -91,7 +91,9 @@ class TestOneClickSigninSyncObserver : public OneClickSigninSyncObserver {
const DestructionCallback& callback)
: OneClickSigninSyncObserver(web_contents, continue_url),
destruction_callback_(callback) {}
- virtual ~TestOneClickSigninSyncObserver() { destruction_callback_.Run(this); }
+ ~TestOneClickSigninSyncObserver() override {
+ destruction_callback_.Run(this);
+ }
private:
DestructionCallback destruction_callback_;

Powered by Google App Engine
This is Rietveld 408576698