Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Unified Diff: chrome/browser/ui/app_list/search/app_result.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/search/app_result.h
diff --git a/chrome/browser/ui/app_list/search/app_result.h b/chrome/browser/ui/app_list/search/app_result.h
index dcbe8ed79a9b71b8bfe466cde2ab493c63be5946..05054c801183262f324ba9b9a97d63f155dac670 100644
--- a/chrome/browser/ui/app_list/search/app_result.h
+++ b/chrome/browser/ui/app_list/search/app_result.h
@@ -41,7 +41,7 @@ class AppResult : public SearchResult,
AppResult(Profile* profile,
const std::string& app_id,
AppListControllerDelegate* controller);
- virtual ~AppResult();
+ ~AppResult() override;
void UpdateFromMatch(const TokenizedString& title,
const TokenizedStringMatch& match);
@@ -50,9 +50,9 @@ class AppResult : public SearchResult,
const base::Time& last_launched);
// SearchResult overrides:
- virtual void Open(int event_flags) override;
- virtual scoped_ptr<SearchResult> Duplicate() override;
- virtual ui::MenuModel* GetContextMenuModel() override;
+ void Open(int event_flags) override;
+ scoped_ptr<SearchResult> Duplicate() override;
+ ui::MenuModel* GetContextMenuModel() override;
private:
void StartObservingExtensionRegistry();
@@ -67,25 +67,22 @@ class AppResult : public SearchResult,
void UpdateIcon();
// extensions::IconImage::Observer overrides:
- virtual void OnExtensionIconImageChanged(
- extensions::IconImage* image) override;
+ void OnExtensionIconImageChanged(extensions::IconImage* image) override;
// AppContextMenuDelegate overrides:
- virtual void ExecuteLaunchCommand(int event_flags) override;
+ void ExecuteLaunchCommand(int event_flags) override;
// ExtensionEnableFlowDelegate overrides:
- virtual void ExtensionEnableFlowFinished() override;
- virtual void ExtensionEnableFlowAborted(bool user_initiated) override;
+ void ExtensionEnableFlowFinished() override;
+ void ExtensionEnableFlowAborted(bool user_initiated) override;
// extensions::ExtensionRegistryObserver override:
- virtual void OnExtensionLoaded(
- content::BrowserContext* browser_context,
- const extensions::Extension* extension) override;
- virtual void OnExtensionUninstalled(
- content::BrowserContext* browser_context,
- const extensions::Extension* extension,
- extensions::UninstallReason reason) override;
- virtual void OnShutdown(extensions::ExtensionRegistry* registry) override;
+ void OnExtensionLoaded(content::BrowserContext* browser_context,
+ const extensions::Extension* extension) override;
+ void OnExtensionUninstalled(content::BrowserContext* browser_context,
+ const extensions::Extension* extension,
+ extensions::UninstallReason reason) override;
+ void OnShutdown(extensions::ExtensionRegistry* registry) override;
Profile* profile_;
const std::string app_id_;

Powered by Google App Engine
This is Rietveld 408576698