chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h

diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h

index 73ccbc8967da4a385236a77e84c0941c259e7c81..33b431143e388d1ad3485c3c2a8519031e831d86 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h

+++ b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h

@@ -31,15 +31,14 @@ class ExtensionInstallDialogController :

const ExtensionInstallPrompt::ShowParams& show_params,

ExtensionInstallPrompt::Delegate* delegate,

scoped_refptr<ExtensionInstallPrompt::Prompt> prompt);

- virtual ~ExtensionInstallDialogController();

+ ~ExtensionInstallDialogController() override;

// ExtensionInstallPrompt::Delegate implementation.

- virtual void InstallUIProceed() override;

- virtual void InstallUIAbort(bool user_initiated) override;

+ void InstallUIProceed() override;

+ void InstallUIAbort(bool user_initiated) override;

// ConstrainedWindowMacDelegate implementation.

- virtual void OnConstrainedWindowClosed(

- ConstrainedWindowMac* window) override;

+ void OnConstrainedWindowClosed(ConstrainedWindowMac* window) override;

ConstrainedWindowMac* constrained_window() const {

return constrained_window_.get();