Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: chrome/browser/ui/login/login_prompt.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/login/login_prompt.h
diff --git a/chrome/browser/ui/login/login_prompt.h b/chrome/browser/ui/login/login_prompt.h
index 5b05c812654e610ac3848f9bcec8b8aeb063bfab..2da56397dd64f44a5e33050d0fd0b357fb72278c 100644
--- a/chrome/browser/ui/login/login_prompt.h
+++ b/chrome/browser/ui/login/login_prompt.h
@@ -41,7 +41,7 @@ class LoginHandler : public content::ResourceDispatcherHostLoginDelegate,
net::URLRequest* request);
// ResourceDispatcherHostLoginDelegate implementation:
- virtual void OnRequestCancelled() override;
+ void OnRequestCancelled() override;
// Initializes the underlying platform specific view.
virtual void BuildViewForPasswordManager(
@@ -68,9 +68,9 @@ class LoginHandler : public content::ResourceDispatcherHostLoginDelegate,
// Listens for AUTH_SUPPLIED and AUTH_CANCELLED notifications from other
// LoginHandlers so that this LoginHandler has the chance to dismiss itself
// if it was waiting for the same authentication.
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override;
+ void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) override;
// Who/where/what asked for the authentication.
const net::AuthChallengeInfo* auth_info() const { return auth_info_.get(); }
@@ -79,7 +79,7 @@ class LoginHandler : public content::ResourceDispatcherHostLoginDelegate,
bool WasAuthHandled() const;
protected:
- virtual ~LoginHandler();
+ ~LoginHandler() override;
void SetModel(password_manager::LoginModel* model);

Powered by Google App Engine
This is Rietveld 408576698