chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/cocoa/profiles/user_manager_mac.mm ('k') | chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.h

diff --git a/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.h b/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.h

index 3fc318a0e7648d4fad5a0674795028522da9ae27..c383e9c88f74acb947a6c139c27faf416bf3f3bb 100644

--- a/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.h

+++ b/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.h

@@ -20,21 +20,20 @@ class RenderViewContextMenuMac : public RenderViewContextMenu {

RenderViewContextMenuMac(content::RenderFrameHost* render_frame_host,

const content::ContextMenuParams& params,

NSView* parent_view);

- virtual ~RenderViewContextMenuMac();

+ ~RenderViewContextMenuMac() override;

// SimpleMenuModel::Delegate implementation.

- virtual void ExecuteCommand(int command_id, int event_flags) override;

- virtual bool IsCommandIdChecked(int command_id) const override;

- virtual bool IsCommandIdEnabled(int command_id) const override;

+ void ExecuteCommand(int command_id, int event_flags) override;

+ bool IsCommandIdChecked(int command_id) const override;

+ bool IsCommandIdEnabled(int command_id) const override;

void Show();

protected:

// RenderViewContextMenu implementation.

- virtual bool GetAcceleratorForCommandId(

- int command_id,

- ui::Accelerator* accelerator) override;

- virtual void AppendPlatformEditableItems() override;

+ bool GetAcceleratorForCommandId(int command_id,

+ ui::Accelerator* accelerator) override;

+ void AppendPlatformEditableItems() override;

private:

friend class ToolkitDelegateMac;