Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5490)

Unified Diff: chrome/browser/ui/panels/docked_panel_collection.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/docked_panel_collection.h
diff --git a/chrome/browser/ui/panels/docked_panel_collection.h b/chrome/browser/ui/panels/docked_panel_collection.h
index 847bf8b67391e7a1bcd1caf0b27c3635c7ad2955..99b1856de11f691abc959f56b426a32cb2c1732a 100644
--- a/chrome/browser/ui/panels/docked_panel_collection.h
+++ b/chrome/browser/ui/panels/docked_panel_collection.h
@@ -27,51 +27,48 @@ class DockedPanelCollection :
typedef std::list<Panel*> Panels;
explicit DockedPanelCollection(PanelManager* panel_manager);
- virtual ~DockedPanelCollection();
+ ~DockedPanelCollection() override;
// PanelCollection OVERRIDES:
- virtual void OnDisplayChanged() override;
+ void OnDisplayChanged() override;
// Rearranges the positions of the panels in the collection
// and reduces their width when there is not enough room.
// This is called when the display space has been changed, i.e. working
// area being changed or a panel being closed.
- virtual void RefreshLayout() override;
+ void RefreshLayout() override;
// Adds a panel to the collection. The panel may be a newly created panel or
// one that is transitioning from another grouping of panels.
- virtual void AddPanel(Panel* panel,
- PositioningMask positioning_mask) override;
- virtual void RemovePanel(Panel* pane, RemovalReason reasonl) override;
- virtual void CloseAll() override;
- virtual void ResizePanelWindow(
- Panel* panel,
- const gfx::Size& preferred_window_size) override;
- virtual panel::Resizability GetPanelResizability(
- const Panel* panel) const override;
- virtual void OnPanelResizedByMouse(Panel* panel,
- const gfx::Rect& new_bounds) override;
- virtual void OnPanelAttentionStateChanged(Panel* panel) override;
- virtual void OnPanelTitlebarClicked(Panel* panel,
- panel::ClickModifier modifier) override;
- virtual void ActivatePanel(Panel* panel) override;
- virtual void MinimizePanel(Panel* panel) override;
- virtual void RestorePanel(Panel* panel) override;
- virtual void OnMinimizeButtonClicked(Panel* panel,
- panel::ClickModifier modifier) override;
- virtual void OnRestoreButtonClicked(Panel* panel,
- panel::ClickModifier modifier) override;
- virtual bool CanShowMinimizeButton(const Panel* panel) const override;
- virtual bool CanShowRestoreButton(const Panel* panel) const override;
- virtual bool IsPanelMinimized(const Panel* panel) const override;
- virtual bool UsesAlwaysOnTopPanels() const override;
- virtual void SavePanelPlacement(Panel* panel) override;
- virtual void RestorePanelToSavedPlacement() override;
- virtual void DiscardSavedPanelPlacement() override;
- virtual void UpdatePanelOnCollectionChange(Panel* panel) override;
- virtual void OnPanelExpansionStateChanged(Panel* panel) override;
- virtual void OnPanelActiveStateChanged(Panel* panel) override;
- virtual gfx::Rect GetInitialPanelBounds(
+ void AddPanel(Panel* panel, PositioningMask positioning_mask) override;
+ void RemovePanel(Panel* pane, RemovalReason reasonl) override;
+ void CloseAll() override;
+ void ResizePanelWindow(Panel* panel,
+ const gfx::Size& preferred_window_size) override;
+ panel::Resizability GetPanelResizability(const Panel* panel) const override;
+ void OnPanelResizedByMouse(Panel* panel,
+ const gfx::Rect& new_bounds) override;
+ void OnPanelAttentionStateChanged(Panel* panel) override;
+ void OnPanelTitlebarClicked(Panel* panel,
+ panel::ClickModifier modifier) override;
+ void ActivatePanel(Panel* panel) override;
+ void MinimizePanel(Panel* panel) override;
+ void RestorePanel(Panel* panel) override;
+ void OnMinimizeButtonClicked(Panel* panel,
+ panel::ClickModifier modifier) override;
+ void OnRestoreButtonClicked(Panel* panel,
+ panel::ClickModifier modifier) override;
+ bool CanShowMinimizeButton(const Panel* panel) const override;
+ bool CanShowRestoreButton(const Panel* panel) const override;
+ bool IsPanelMinimized(const Panel* panel) const override;
+ bool UsesAlwaysOnTopPanels() const override;
+ void SavePanelPlacement(Panel* panel) override;
+ void RestorePanelToSavedPlacement() override;
+ void DiscardSavedPanelPlacement() override;
+ void UpdatePanelOnCollectionChange(Panel* panel) override;
+ void OnPanelExpansionStateChanged(Panel* panel) override;
+ void OnPanelActiveStateChanged(Panel* panel) override;
+ gfx::Rect GetInitialPanelBounds(
const gfx::Rect& requested_bounds) const override;
// Returns true if we should bring up the titlebars, given the current mouse
@@ -128,13 +125,13 @@ class DockedPanelCollection :
};
// Overridden from PanelMouseWatcherObserver:
- virtual void OnMouseMove(const gfx::Point& mouse_position) override;
+ void OnMouseMove(const gfx::Point& mouse_position) override;
// Overridden from DisplaySettingsProvider::DesktopBarObserver:
- virtual void OnAutoHidingDesktopBarVisibilityChanged(
+ void OnAutoHidingDesktopBarVisibilityChanged(
DisplaySettingsProvider::DesktopBarAlignment alignment,
DisplaySettingsProvider::DesktopBarVisibility visibility) override;
- virtual void OnAutoHidingDesktopBarThicknessChanged(
+ void OnAutoHidingDesktopBarThicknessChanged(
DisplaySettingsProvider::DesktopBarAlignment alignment,
int thickness) override;

Powered by Google App Engine
This is Rietveld 408576698