Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Unified Diff: chrome/browser/ui/cocoa/login_prompt_cocoa.mm

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/login_prompt_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/login_prompt_cocoa.mm b/chrome/browser/ui/cocoa/login_prompt_cocoa.mm
index 9986a1ebac8f66478cf2f49418a6f85670956a70..e1e1725d0d07bc8a3cebed6bbe60dd197cd98251 100644
--- a/chrome/browser/ui/cocoa/login_prompt_cocoa.mm
+++ b/chrome/browser/ui/cocoa/login_prompt_cocoa.mm
@@ -41,20 +41,18 @@ class LoginHandlerMac : public LoginHandler,
}
// LoginModelObserver implementation.
- virtual void OnAutofillDataAvailable(
- const base::string16& username,
- const base::string16& password) override {
+ void OnAutofillDataAvailable(const base::string16& username,
+ const base::string16& password) override {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
[sheet_controller_ autofillLogin:base::SysUTF16ToNSString(username)
password:base::SysUTF16ToNSString(password)];
}
- virtual void OnLoginModelDestroying() override {}
+ void OnLoginModelDestroying() override {}
// LoginHandler:
- virtual void BuildViewForPasswordManager(
- password_manager::PasswordManager* manager,
- const base::string16& explanation) override {
+ void BuildViewForPasswordManager(password_manager::PasswordManager* manager,
+ const base::string16& explanation) override {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
sheet_controller_.reset(
@@ -81,15 +79,14 @@ class LoginHandlerMac : public LoginHandler,
NotifyAuthNeeded();
}
- virtual void CloseDialog() override {
+ void CloseDialog() override {
// The hosting dialog may have been freed.
if (constrained_window_)
constrained_window_->CloseWebContentsModalDialog();
}
// Overridden from ConstrainedWindowMacDelegate:
- virtual void OnConstrainedWindowClosed(
- ConstrainedWindowMac* window) override {
+ void OnConstrainedWindowClosed(ConstrainedWindowMac* window) override {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
SetModel(NULL);
ReleaseSoon();
@@ -112,7 +109,7 @@ class LoginHandlerMac : public LoginHandler,
private:
friend class LoginPrompt;
- virtual ~LoginHandlerMac() {
+ ~LoginHandlerMac() override {
// This class will be deleted on a non UI thread. Ensure that the UI members
// have already been deleted.
CHECK(!constrained_window_.get());

Powered by Google App Engine
This is Rietveld 408576698