Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: chrome/browser/ui/browser_command_controller_unittest.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_command_controller_unittest.cc
diff --git a/chrome/browser/ui/browser_command_controller_unittest.cc b/chrome/browser/ui/browser_command_controller_unittest.cc
index d387eb4408cddf5425c624b94811cd07d9edc023..3eef13c41e4cd3737e43b032ae4faba714dbb2d8 100644
--- a/chrome/browser/ui/browser_command_controller_unittest.cc
+++ b/chrome/browser/ui/browser_command_controller_unittest.cc
@@ -306,22 +306,16 @@ TEST_F(BrowserCommandControllerTest, AvatarMenuAlwaysDisabledInIncognitoMode) {
class FullscreenTestBrowserWindow : public TestBrowserWindow {
public:
FullscreenTestBrowserWindow() : fullscreen_(false) {}
- virtual ~FullscreenTestBrowserWindow() {}
+ ~FullscreenTestBrowserWindow() override {}
// TestBrowserWindow overrides:
- virtual bool ShouldHideUIForFullscreen() const override {
- return fullscreen_;
- }
- virtual bool IsFullscreen() const override {
- return fullscreen_;
- }
- virtual void EnterFullscreen(
- const GURL& url, FullscreenExitBubbleType type) override {
+ bool ShouldHideUIForFullscreen() const override { return fullscreen_; }
+ bool IsFullscreen() const override { return fullscreen_; }
+ void EnterFullscreen(const GURL& url,
+ FullscreenExitBubbleType type) override {
fullscreen_ = true;
}
- virtual void ExitFullscreen() override {
- fullscreen_ = false;
- }
+ void ExitFullscreen() override { fullscreen_ = false; }
private:
bool fullscreen_;
@@ -337,7 +331,7 @@ class BrowserCommandControllerFullscreenTest
virtual ~BrowserCommandControllerFullscreenTest() {}
// BrowserWithTestWindowTest overrides:
- virtual BrowserWindow* CreateBrowserWindow() override {
+ BrowserWindow* CreateBrowserWindow() override {
return new FullscreenTestBrowserWindow;
}

Powered by Google App Engine
This is Rietveld 408576698