Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4920)

Unified Diff: chrome/browser/ui/webui/memory_internals/memory_internals_proxy.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/memory_internals/memory_internals_proxy.cc
diff --git a/chrome/browser/ui/webui/memory_internals/memory_internals_proxy.cc b/chrome/browser/ui/webui/memory_internals/memory_internals_proxy.cc
index ac5b46fb05e6ab0fe77a1ab96e34c9ca44f04bdd..887821aee917f5578fe642312ba17240335612ab 100644
--- a/chrome/browser/ui/webui/memory_internals/memory_internals_proxy.cc
+++ b/chrome/browser/ui/webui/memory_internals/memory_internals_proxy.cc
@@ -53,14 +53,14 @@ class ProcessDetails : public MemoryDetails {
explicit ProcessDetails(const DataCallback& callback)
: callback_(callback) {}
// MemoryDetails:
- virtual void OnDetailsAvailable() override {
+ void OnDetailsAvailable() override {
const std::vector<ProcessData>& browser_processes = processes();
// [0] means Chrome.
callback_.Run(browser_processes[0]);
}
private:
- virtual ~ProcessDetails() {}
+ ~ProcessDetails() override {}
DataCallback callback_;
@@ -129,7 +129,7 @@ class RendererDetails : public content::NotificationObserver {
registrar_.Add(this, chrome::NOTIFICATION_RENDERER_V8_HEAP_STATS_COMPUTED,
content::NotificationService::AllSources());
}
- virtual ~RendererDetails() {}
+ ~RendererDetails() override {}
void Request() {
for (std::set<content::WebContents*>::iterator iter = web_contents_.begin();
@@ -157,9 +157,9 @@ class RendererDetails : public content::NotificationObserver {
private:
// NotificationObserver:
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override {
+ void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) override {
const base::ProcessId* pid =
content::Source<const base::ProcessId>(source).ptr();
const ChromeRenderMessageFilter::V8HeapStatsDetails* v8_heap =

Powered by Google App Engine
This is Rietveld 408576698