chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/webui/options/website_settings_handler.h ('k') | chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.h

diff --git a/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.h b/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.h

index 5fa8c3b5ff59283614171e0e125a42781aa398c2..5b80e86f0df781774994d15135fa58c9b2e9f553 100644

--- a/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.h

+++ b/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.h

@@ -14,16 +14,14 @@ class PasswordManagerInternalsUI : public content::WebUIController,

public password_manager::LogReceiver {

public:

explicit PasswordManagerInternalsUI(content::WebUI* web_ui);

- virtual ~PasswordManagerInternalsUI();

+ ~PasswordManagerInternalsUI() override;

// WebContentsObserver implementation.

- virtual void DidStartLoading(

- content::RenderViewHost* render_view_host) override;

- virtual void DidStopLoading(

- content::RenderViewHost* render_view_host) override;

+ void DidStartLoading(content::RenderViewHost* render_view_host) override;

+ void DidStopLoading(content::RenderViewHost* render_view_host) override;

// LogReceiver implementation.

- virtual void LogSavePasswordProgress(const std::string& text) override;

+ void LogSavePasswordProgress(const std::string& text) override;

private:

// If currently registered with PasswordManagerInternalsService, unregisters