Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: chrome/browser/ui/panels/panel.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel.cc
diff --git a/chrome/browser/ui/panels/panel.cc b/chrome/browser/ui/panels/panel.cc
index c1bd50cdd82b226962dd1743f314fc3da780548d..ce8b7189c901738a19d3a550e06fa423af61f6c0 100644
--- a/chrome/browser/ui/panels/panel.cc
+++ b/chrome/browser/ui/panels/panel.cc
@@ -51,19 +51,19 @@ namespace panel_internal {
class PanelExtensionWindowController : public extensions::WindowController {
public:
PanelExtensionWindowController(Panel* panel, Profile* profile);
- virtual ~PanelExtensionWindowController();
+ ~PanelExtensionWindowController() override;
// Overridden from extensions::WindowController.
- virtual int GetWindowId() const override;
- virtual std::string GetWindowTypeText() const override;
- virtual base::DictionaryValue* CreateWindowValueWithTabs(
+ int GetWindowId() const override;
+ std::string GetWindowTypeText() const override;
+ base::DictionaryValue* CreateWindowValueWithTabs(
const extensions::Extension* extension) const override;
- virtual base::DictionaryValue* CreateTabValue(
- const extensions::Extension* extension, int tab_index) const override;
- virtual bool CanClose(Reason* reason) const override;
- virtual void SetFullscreenMode(bool is_fullscreen,
- const GURL& extension_url) const override;
- virtual bool IsVisibleToExtension(
+ base::DictionaryValue* CreateTabValue(const extensions::Extension* extension,
+ int tab_index) const override;
+ bool CanClose(Reason* reason) const override;
+ void SetFullscreenMode(bool is_fullscreen,
+ const GURL& extension_url) const override;
+ bool IsVisibleToExtension(
const extensions::Extension* extension) const override;
private:

Powered by Google App Engine
This is Rietveld 408576698