chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.h ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm

index 3e3588a908e894c4b6fa807e41d8e2aeaad5cc54..77a58df3e7fd4b79ae629956fd9545f4109a8e11 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm

@@ -26,17 +26,13 @@ class TestBookmarkMenuBridge : public BookmarkMenuBridge {

: BookmarkMenuBridge(profile, menu),

menu_(menu) {

}

- virtual ~TestBookmarkMenuBridge() {

- [menu_ autorelease];

- }

+ ~TestBookmarkMenuBridge() override { [menu_ autorelease]; }

NSMenu* menu_;

protected:

// Overridden from BookmarkMenuBridge.

- virtual NSMenu* BookmarkMenu() override {

- return menu_;

- }

+ NSMenu* BookmarkMenu() override { return menu_; }

};

// TODO(jrg): see refactor comment in bookmark_bar_state_controller_unittest.mm