chrome/browser/ui/cocoa/location_bar/star_decoration.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/star_decoration.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.h ('k') | chrome/browser/ui/cocoa/location_bar/translate_decoration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/location_bar/star_decoration.h

diff --git a/chrome/browser/ui/cocoa/location_bar/star_decoration.h b/chrome/browser/ui/cocoa/location_bar/star_decoration.h

index ef9f8d6c4ef105bfa853a856e370e04b16e79403..20a0741d7024a27b832dd18c5c23c1c103abb319 100644

--- a/chrome/browser/ui/cocoa/location_bar/star_decoration.h

+++ b/chrome/browser/ui/cocoa/location_bar/star_decoration.h

@@ -16,7 +16,7 @@ class CommandUpdater;

class StarDecoration : public ImageDecoration {

public:

explicit StarDecoration(CommandUpdater* command_updater);

- virtual ~StarDecoration();

+ ~StarDecoration() override;

// Sets the image and tooltip based on |starred|.

void SetStarred(bool starred);

@@ -25,10 +25,10 @@ class StarDecoration : public ImageDecoration {

bool starred() const { return starred_; }

// Implement |LocationBarDecoration|.

- virtual bool AcceptsMousePress() override;

- virtual bool OnMousePressed(NSRect frame, NSPoint location) override;

- virtual NSString* GetToolTip() override;

- virtual NSPoint GetBubblePointInFrame(NSRect frame) override;

+ bool AcceptsMousePress() override;

+ bool OnMousePressed(NSRect frame, NSPoint location) override;

+ NSString* GetToolTip() override;

+ NSPoint GetBubblePointInFrame(NSRect frame) override;

private:

// For bringing up bookmark bar.