Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: chrome/browser/ui/app_list/app_list_service_mac_interactive_uitest.mm

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/app_list_service_mac_interactive_uitest.mm
diff --git a/chrome/browser/ui/app_list/app_list_service_mac_interactive_uitest.mm b/chrome/browser/ui/app_list/app_list_service_mac_interactive_uitest.mm
index d3f8c5263c2c97a11dfbe6e441d112aeb09f622f..e8ad02ab24fef535a08bc47c075c537ed7423f2d 100644
--- a/chrome/browser/ui/app_list/app_list_service_mac_interactive_uitest.mm
+++ b/chrome/browser/ui/app_list/app_list_service_mac_interactive_uitest.mm
@@ -62,25 +62,20 @@ class AppListServiceMacInteractiveTest : public InProcessBrowserTest,
}
// AppShimHandler::Host overrides:
- virtual void OnAppLaunchComplete(apps::AppShimLaunchResult result) override {
+ void OnAppLaunchComplete(apps::AppShimLaunchResult result) override {
// AppList shims are always given APP_SHIM_LAUNCH_DUPLICATE_HOST, indicating
// that the shim process should immediately close.
EXPECT_EQ(apps::APP_SHIM_LAUNCH_DUPLICATE_HOST, result);
++launch_count_;
}
- virtual void OnAppClosed() override {
- NOTREACHED();
- }
- virtual void OnAppHide() override {}
- virtual void OnAppRequestUserAttention(
- apps::AppShimAttentionType type) override {}
- virtual base::FilePath GetProfilePath() const override {
+ void OnAppClosed() override { NOTREACHED(); }
+ void OnAppHide() override {}
+ void OnAppRequestUserAttention(apps::AppShimAttentionType type) override {}
+ base::FilePath GetProfilePath() const override {
NOTREACHED(); // Currently unused in this test.
return base::FilePath();
}
- virtual std::string GetAppId() const override {
- return app_mode::kAppListModeId;
- }
+ std::string GetAppId() const override { return app_mode::kAppListModeId; }
int launch_count_;

Powered by Google App Engine
This is Rietveld 408576698