Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6523)

Unified Diff: chrome/browser/ui/search/search_tab_helper_unittest.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/search_tab_helper_unittest.cc
diff --git a/chrome/browser/ui/search/search_tab_helper_unittest.cc b/chrome/browser/ui/search/search_tab_helper_unittest.cc
index db33f13255a1ef5b8fc29334f9e27f03198a0bd1..7ca1df77836e07603bef270e48a305096f30fc37 100644
--- a/chrome/browser/ui/search/search_tab_helper_unittest.cc
+++ b/chrome/browser/ui/search/search_tab_helper_unittest.cc
@@ -78,7 +78,7 @@ class SearchTabHelperTest : public ChromeRenderViewHostTestHarness {
SearchTabHelper::CreateForWebContents(web_contents());
}
- virtual content::BrowserContext* CreateBrowserContext() override {
+ content::BrowserContext* CreateBrowserContext() override {
TestingProfile::Builder builder;
builder.AddTestingFactory(SigninManagerFactory::GetInstance(),
FakeSigninManagerBase::Build);
@@ -285,7 +285,7 @@ class TabTitleObserver : public content::WebContentsObserver {
base::string16 title_on_commit() { return title_on_commit_; }
private:
- virtual void DidStartProvisionalLoadForFrame(
+ void DidStartProvisionalLoadForFrame(
content::RenderFrameHost* /* render_frame_host */,
const GURL& /* validated_url */,
bool /* is_error_page */,
@@ -293,7 +293,7 @@ class TabTitleObserver : public content::WebContentsObserver {
title_on_start_ = web_contents()->GetTitle();
}
- virtual void DidNavigateMainFrame(
+ void DidNavigateMainFrame(
const content::LoadCommittedDetails& /* details */,
const content::FrameNavigateParams& /* params */) override {
title_on_commit_ = web_contents()->GetTitle();

Powered by Google App Engine
This is Rietveld 408576698