chrome/browser/ui/cocoa/browser/zoom_bubble_controller_unittest.mm - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser/zoom_bubble_controller_unittest.mm

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h ('k') | chrome/browser/ui/cocoa/browser_window_cocoa.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser/zoom_bubble_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/browser/zoom_bubble_controller_unittest.mm b/chrome/browser/ui/cocoa/browser/zoom_bubble_controller_unittest.mm

index 1667f094a8181ec4f60751cf5291e7ba02abfd81..90ec453e57c728187ebb639e68e2882c2fe30f84 100644

--- a/chrome/browser/ui/cocoa/browser/zoom_bubble_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/browser/zoom_bubble_controller_unittest.mm

@@ -20,14 +20,10 @@ class TestZoomBubbleControllerDelegate : public ZoomBubbleControllerDelegate {

TestZoomBubbleControllerDelegate() : did_close_(false) {}

// Get the web contents associated with this bubble.

- virtual content::WebContents* GetWebContents() override {

- return NULL;

- }

+ content::WebContents* GetWebContents() override { return NULL; }

// Called when the bubble is being closed.

- virtual void OnClose() override {

- did_close_ = true;

- }

+ void OnClose() override { did_close_ = true; }

bool did_close() { return did_close_; }