Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc
diff --git a/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc b/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc
index 3df205d71f15bd7e4a414b54c30b77038c46fac3..ce7f2f58c47cd0ce5344d85e7db0ace09ef5a60d 100644
--- a/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc
+++ b/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc
@@ -814,25 +814,25 @@ TEST_F(ContentSettingBubbleModelTest, RegisterProtocolHandler) {
class FakeDelegate : public ProtocolHandlerRegistry::Delegate {
public:
- virtual void RegisterExternalHandler(const std::string& protocol) override {
+ void RegisterExternalHandler(const std::string& protocol) override {
// Overrides in order to not register the handler with the
// ChildProcessSecurityPolicy. That has persistent and unalterable
// side effects on other tests.
}
- virtual ShellIntegration::DefaultProtocolClientWorker* CreateShellWorker(
+ ShellIntegration::DefaultProtocolClientWorker* CreateShellWorker(
ShellIntegration::DefaultWebClientObserver* observer,
const std::string& protocol) override {
VLOG(1) << "CreateShellWorker";
return NULL;
}
- virtual ProtocolHandlerRegistry::DefaultClientObserver* CreateShellObserver(
+ ProtocolHandlerRegistry::DefaultClientObserver* CreateShellObserver(
ProtocolHandlerRegistry* registry) override {
return NULL;
}
- virtual void RegisterWithOSAsDefaultClient(
+ void RegisterWithOSAsDefaultClient(
const std::string& protocol,
ProtocolHandlerRegistry* registry) override {
VLOG(1) << "Register With OS";

Powered by Google App Engine
This is Rietveld 408576698