chrome/browser/ui/apps/directory_access_confirmation_dialog.cc - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/apps/directory_access_confirmation_dialog.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/apps/chrome_app_window_client.h ('k') | chrome/browser/ui/ash/chrome_shell_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/apps/directory_access_confirmation_dialog.cc

diff --git a/chrome/browser/ui/apps/directory_access_confirmation_dialog.cc b/chrome/browser/ui/apps/directory_access_confirmation_dialog.cc

index 2b42da9c2110cf44e4513a7ce07c7b8dd5e6515f..d5299d6efbb5741bab5fc5a19ab9c9444ed969b5 100644

--- a/chrome/browser/ui/apps/directory_access_confirmation_dialog.cc

+++ b/chrome/browser/ui/apps/directory_access_confirmation_dialog.cc

@@ -21,15 +21,15 @@ class DirectoryAccessConfirmationDialog : public TabModalConfirmDialogDelegate {

const base::Closure& on_accept,

const base::Closure& on_cancel);

- virtual base::string16 GetTitle() override;

- virtual base::string16 GetDialogMessage() override;

- virtual base::string16 GetAcceptButtonTitle() override;

- virtual base::string16 GetCancelButtonTitle() override;

+ base::string16 GetTitle() override;

+ base::string16 GetDialogMessage() override;

+ base::string16 GetAcceptButtonTitle() override;

+ base::string16 GetCancelButtonTitle() override;

private:

- virtual void OnAccepted() override;

- virtual void OnCanceled() override;

- virtual void OnClosed() override;

+ void OnAccepted() override;

+ void OnCanceled() override;

+ void OnClosed() override;

const base::Closure on_accept_;

const base::Closure on_cancel_;