chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h ('k') | chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac_interactive_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.h

diff --git a/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.h b/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.h

index 6a342dd93dd02b2fa148681f7667a39884901a6c..67a3ef25e1cad3e2ecfebce633595abc1edc601a 100644

--- a/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.h

+++ b/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.h

@@ -21,12 +21,12 @@ class QuitWithAppsController : public NotificationDelegate {

QuitWithAppsController();

// NotificationDelegate interface.

- virtual void Display() override;

- virtual void Error() override;

- virtual void Close(bool by_user) override;

- virtual void Click() override;

- virtual void ButtonClick(int button_index) override;

- virtual std::string id() const override;

+ void Display() override;

+ void Error() override;

+ void Close(bool by_user) override;

+ void Click() override;

+ void ButtonClick(int button_index) override;

+ std::string id() const override;

// Attempt to quit Chrome. This will display a notification and return false

// if there are apps running.

@@ -36,7 +36,7 @@ class QuitWithAppsController : public NotificationDelegate {

static void RegisterPrefs(PrefRegistrySimple* registry);

private:

- virtual ~QuitWithAppsController();

+ ~QuitWithAppsController() override;

scoped_ptr<Notification> notification_;

// The Profile instance associated with the notification_. We need to cache