chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller_browsertest.mm - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller_browsertest.mm

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_dialog_cocoa.h ('k') | chrome/browser/ui/cocoa/profiles/user_manager_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller_browsertest.mm b/chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller_browsertest.mm

index 7a26b4ccbb1b4aa37e1a86ad0d673c5e062cfb97..9fe87623646cc64fcacef6bdd9ac3f3d81e496d2 100644

--- a/chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller_browsertest.mm

+++ b/chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller_browsertest.mm

@@ -31,8 +31,7 @@ class ProfileSigninConfirmationViewControllerTest

}

protected:

- virtual void SetUpOnMainThread() override {

- }

+ void SetUpOnMainThread() override {}

void SetupDialog(bool offerProfileCreation = true) {

window_.reset(

@@ -63,9 +62,9 @@ class ProfileSigninConfirmationViewControllerTest

}

// ui::ProfileSigninConfirmationDelegate:

- virtual void OnContinueSignin() override { continued_ = true; }

- virtual void OnCancelSignin() override { cancelled_ = true; }

- virtual void OnSigninWithNewProfile() override { created_ = true; }

+ void OnContinueSignin() override { continued_ = true; }

+ void OnCancelSignin() override { cancelled_ = true; }

+ void OnSigninWithNewProfile() override { created_ = true; }

void OnClose() { closed_ = true; }

// The window containing the dialog.