Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4553)

Unified Diff: chrome/browser/ui/autofill/chrome_autofill_client.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/chrome_autofill_client.h
diff --git a/chrome/browser/ui/autofill/chrome_autofill_client.h b/chrome/browser/ui/autofill/chrome_autofill_client.h
index a337dc5d914968b4d43e6ab99517a28a26d2dd70..323eb5f92d95c932e9a0bb95a4e511dfbd8cee24 100644
--- a/chrome/browser/ui/autofill/chrome_autofill_client.h
+++ b/chrome/browser/ui/autofill/chrome_autofill_client.h
@@ -34,25 +34,23 @@ class ChromeAutofillClient
public content::WebContentsObserver,
public ZoomObserver {
public:
- virtual ~ChromeAutofillClient();
+ ~ChromeAutofillClient() override;
// Called when the tab corresponding to |this| instance is activated.
void TabActivated();
// AutofillClient:
- virtual PersonalDataManager* GetPersonalDataManager() override;
- virtual scoped_refptr<AutofillWebDataService> GetDatabase() override;
- virtual PrefService* GetPrefs() override;
- virtual void HideRequestAutocompleteDialog() override;
- virtual void ShowAutofillSettings() override;
- virtual void ConfirmSaveCreditCard(
- const AutofillMetrics& metric_logger,
- const base::Closure& save_card_callback) override;
- virtual void ShowRequestAutocompleteDialog(
- const FormData& form,
- const GURL& source_url,
- const ResultCallback& callback) override;
- virtual void ShowAutofillPopup(
+ PersonalDataManager* GetPersonalDataManager() override;
+ scoped_refptr<AutofillWebDataService> GetDatabase() override;
+ PrefService* GetPrefs() override;
+ void HideRequestAutocompleteDialog() override;
+ void ShowAutofillSettings() override;
+ void ConfirmSaveCreditCard(const AutofillMetrics& metric_logger,
+ const base::Closure& save_card_callback) override;
+ void ShowRequestAutocompleteDialog(const FormData& form,
+ const GURL& source_url,
+ const ResultCallback& callback) override;
+ void ShowAutofillPopup(
const gfx::RectF& element_bounds,
base::i18n::TextDirection text_direction,
const std::vector<base::string16>& values,
@@ -60,23 +58,21 @@ class ChromeAutofillClient
const std::vector<base::string16>& icons,
const std::vector<int>& identifiers,
base::WeakPtr<AutofillPopupDelegate> delegate) override;
- virtual void UpdateAutofillPopupDataListValues(
+ void UpdateAutofillPopupDataListValues(
const std::vector<base::string16>& values,
const std::vector<base::string16>& labels) override;
- virtual void HideAutofillPopup() override;
- virtual bool IsAutocompleteEnabled() override;
- virtual void DetectAccountCreationForms(
+ void HideAutofillPopup() override;
+ bool IsAutocompleteEnabled() override;
+ void DetectAccountCreationForms(
const std::vector<autofill::FormStructure*>& forms) override;
- virtual void DidFillOrPreviewField(
- const base::string16& autofilled_value,
- const base::string16& profile_full_name) override;
+ void DidFillOrPreviewField(const base::string16& autofilled_value,
+ const base::string16& profile_full_name) override;
// content::WebContentsObserver implementation.
- virtual void WebContentsDestroyed() override;
+ void WebContentsDestroyed() override;
// ZoomObserver implementation.
- virtual void OnZoomChanged(
- const ZoomController::ZoomChangedEventData& data) override;
+ void OnZoomChanged(const ZoomController::ZoomChangedEventData& data) override;
// Exposed for testing.
AutofillDialogController* GetDialogControllerForTesting() {

Powered by Google App Engine
This is Rietveld 408576698