Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: chrome/browser/ui/browser_unittest.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_unittest.cc
diff --git a/chrome/browser/ui/browser_unittest.cc b/chrome/browser/ui/browser_unittest.cc
index 0eb1adbf0beef9601da791690e45f2e765f4b661..a7e79f6f71fa9c612e3a37df77abf31b5b691725 100644
--- a/chrome/browser/ui/browser_unittest.cc
+++ b/chrome/browser/ui/browser_unittest.cc
@@ -84,7 +84,7 @@ class BrowserBookmarkBarTest : public BrowserWithTestWindowTest {
browser()->window())->set_browser(browser());
}
- virtual BrowserWindow* CreateBrowserWindow() override {
+ BrowserWindow* CreateBrowserWindow() override {
return new BookmarkBarStateTestBrowserWindow();
}
@@ -94,7 +94,7 @@ class BrowserBookmarkBarTest : public BrowserWithTestWindowTest {
BookmarkBarStateTestBrowserWindow()
: browser_(NULL),
bookmark_bar_state_(BookmarkBar::HIDDEN) {}
- virtual ~BookmarkBarStateTestBrowserWindow() {}
+ ~BookmarkBarStateTestBrowserWindow() override {}
void set_browser(Browser* browser) { browser_ = browser; }
@@ -104,16 +104,16 @@ class BrowserBookmarkBarTest : public BrowserWithTestWindowTest {
private:
// TestBrowserWindow:
- virtual void BookmarkBarStateChanged(
+ void BookmarkBarStateChanged(
BookmarkBar::AnimateChangeType change_type) override {
bookmark_bar_state_ = browser_->bookmark_bar_state();
TestBrowserWindow::BookmarkBarStateChanged(change_type);
}
- virtual void OnActiveTabChanged(content::WebContents* old_contents,
- content::WebContents* new_contents,
- int index,
- int reason) override {
+ void OnActiveTabChanged(content::WebContents* old_contents,
+ content::WebContents* new_contents,
+ int index,
+ int reason) override {
bookmark_bar_state_ = browser_->bookmark_bar_state();
TestBrowserWindow::OnActiveTabChanged(old_contents, new_contents, index,
reason);

Powered by Google App Engine
This is Rietveld 408576698