chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/cocoa/location_bar/mic_search_decoration.h ('k') | chrome/browser/ui/cocoa/location_bar/page_action_decoration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.h

diff --git a/chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.h b/chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.h

index 282ffbc0292a1eb6b70b34b33006b97616105aac..ae8716bf360fd40cce00accf02604ef0b54fbecb 100644

--- a/chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.h

+++ b/chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.h

@@ -29,29 +29,28 @@ class OriginChipDecoration : public ButtonDecoration,

public:

OriginChipDecoration(LocationBarViewMac* owner,

LocationIconDecoration* location_icon);

- virtual ~OriginChipDecoration();

+ ~OriginChipDecoration() override;

// Updates the origin chip's content, and display state.

void Update();

// Implement |ButtonDecoration|.

- virtual bool PreventFocus(NSPoint location) const override;

+ bool PreventFocus(NSPoint location) const override;

// Implement |LocationBarDecoration|.

- virtual CGFloat GetWidthForSpace(CGFloat width) override;

- virtual void DrawInFrame(NSRect frame, NSView* control_view) override;

- virtual NSString* GetToolTip() override;

- virtual bool OnMousePressed(NSRect frame, NSPoint location) override;

- virtual NSPoint GetBubblePointInFrame(NSRect frame) override;

+ CGFloat GetWidthForSpace(CGFloat width) override;

+ void DrawInFrame(NSRect frame, NSView* control_view) override;

+ NSString* GetToolTip() override;

+ bool OnMousePressed(NSRect frame, NSPoint location) override;

+ NSPoint GetBubblePointInFrame(NSRect frame) override;

// Implement |IconImage::Observer|.

- virtual void OnExtensionIconImageChanged(

- extensions::IconImage* image) override;

+ void OnExtensionIconImageChanged(extensions::IconImage* image) override;

// Implement |SafeBrowsingUIManager::Observer|.

- virtual void OnSafeBrowsingHit(

+ void OnSafeBrowsingHit(

const SafeBrowsingUIManager::UnsafeResource& resource) override;

- virtual void OnSafeBrowsingMatch(

+ void OnSafeBrowsingMatch(

const SafeBrowsingUIManager::UnsafeResource& resource) override;

private: