Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: chrome/browser/ui/app_list/app_list_syncable_service.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/app_list_syncable_service.cc
diff --git a/chrome/browser/ui/app_list/app_list_syncable_service.cc b/chrome/browser/ui/app_list/app_list_syncable_service.cc
index 3a6aa09b2e5c932745b53d294c299652aa90ba13..272da314b5ea6f2218c73a8344035364cab09ee2 100644
--- a/chrome/browser/ui/app_list/app_list_syncable_service.cc
+++ b/chrome/browser/ui/app_list/app_list_syncable_service.cc
@@ -184,14 +184,14 @@ class AppListSyncableService::ModelObserver : public AppListModelObserver {
owner_->model()->AddObserver(this);
}
- virtual ~ModelObserver() {
+ ~ModelObserver() override {
owner_->model()->RemoveObserver(this);
DVLOG(2) << owner_ << ": ModelObserver Removed";
}
private:
// AppListModelObserver
- virtual void OnAppListItemAdded(AppListItem* item) override {
+ void OnAppListItemAdded(AppListItem* item) override {
DCHECK(!adding_item_);
adding_item_ = item; // Ignore updates while adding an item.
VLOG(2) << owner_ << " OnAppListItemAdded: " << item->ToDebugString();
@@ -199,7 +199,7 @@ class AppListSyncableService::ModelObserver : public AppListModelObserver {
adding_item_ = NULL;
}
- virtual void OnAppListItemWillBeDeleted(AppListItem* item) override {
+ void OnAppListItemWillBeDeleted(AppListItem* item) override {
DCHECK(!adding_item_);
VLOG(2) << owner_ << " OnAppListItemDeleted: " << item->ToDebugString();
// Don't sync folder removal in case the folder still exists on another
@@ -210,7 +210,7 @@ class AppListSyncableService::ModelObserver : public AppListModelObserver {
owner_->RemoveSyncItem(item->id());
}
- virtual void OnAppListItemUpdated(AppListItem* item) override {
+ void OnAppListItemUpdated(AppListItem* item) override {
if (adding_item_) {
// Adding an item may trigger update notifications which should be
// ignored.

Powered by Google App Engine
This is Rietveld 408576698