chrome/browser/ui/content_settings/content_setting_image_model_unittest.cc - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/content_settings/content_setting_image_model_unittest.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/content_settings/content_setting_image_model.cc ('k') | chrome/browser/ui/content_settings/content_setting_media_menu_model.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/content_settings/content_setting_image_model_unittest.cc

diff --git a/chrome/browser/ui/content_settings/content_setting_image_model_unittest.cc b/chrome/browser/ui/content_settings/content_setting_image_model_unittest.cc

index df964cdfb7269ccb23da86a47fad24b9540d437a..18f228b57d17a227e5ea03076bfd654a2ce770dd 100644

--- a/chrome/browser/ui/content_settings/content_setting_image_model_unittest.cc

+++ b/chrome/browser/ui/content_settings/content_setting_image_model_unittest.cc

@@ -30,15 +30,15 @@ class NotificationForwarder : public content::NotificationObserver {

chrome::NOTIFICATION_WEB_CONTENT_SETTINGS_CHANGED,

content::NotificationService::AllSources());

}

- virtual ~NotificationForwarder() {}

+ ~NotificationForwarder() override {}

void clear() {

registrar_.RemoveAll();

}

- virtual void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override {

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override {

if (type == chrome::NOTIFICATION_WEB_CONTENT_SETTINGS_CHANGED) {

model_->UpdateFromWebContents(

content::Source<content::WebContents>(source).ptr());