chrome/browser/ui/app_list/search/people/people_provider_browsertest.cc - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/search/people/people_provider_browsertest.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/app_list/search/people/people_provider.h ('k') | chrome/browser/ui/app_list/search/people/people_result.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/search/people/people_provider_browsertest.cc

diff --git a/chrome/browser/ui/app_list/search/people/people_provider_browsertest.cc b/chrome/browser/ui/app_list/search/people/people_provider_browsertest.cc

index b0eec31dbf12072bbb8202d70f115b3e90b080dc..ce634f3d74133ead570cc16442ea42a154f7f5e6 100644

--- a/chrome/browser/ui/app_list/search/people/people_provider_browsertest.cc

+++ b/chrome/browser/ui/app_list/search/people/people_provider_browsertest.cc

@@ -166,7 +166,7 @@ class PeopleProviderTest : public InProcessBrowserTest {

virtual ~PeopleProviderTest() {}

// InProcessBrowserTest overrides:

- virtual void SetUpOnMainThread() override {

+ void SetUpOnMainThread() override {

test_server_.reset(new EmbeddedTestServer);

ASSERT_TRUE(test_server_->InitializeAndWaitUntilReady());

@@ -184,7 +184,7 @@ class PeopleProviderTest : public InProcessBrowserTest {

people_provider_->set_use_throttling(false);

}

- virtual void TearDownOnMainThread() override {

+ void TearDownOnMainThread() override {

EXPECT_TRUE(test_server_->ShutdownAndWaitUntilComplete());

test_server_.reset();

}