chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/webui/components_ui.cc ('k') | chrome/browser/ui/webui/constrained_web_dialog_ui.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h

diff --git a/chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h b/chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h

index 9f3a1c705dcd831c4fa4af2004f184bf18ba24c6..2a4d442abbc9ed1398e7e8fdde7ee5fb6019762c 100644

--- a/chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h

+++ b/chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h

@@ -26,20 +26,20 @@ class ConstrainedWebDialogDelegateBase

ConstrainedWebDialogDelegateBase(content::BrowserContext* browser_context,

ui::WebDialogDelegate* delegate,

WebDialogWebContentsDelegate* tab_delegate);

- virtual ~ConstrainedWebDialogDelegateBase();

+ ~ConstrainedWebDialogDelegateBase() override;

bool closed_via_webui() const;

// ConstrainedWebDialogDelegate interface.

- virtual const ui::WebDialogDelegate* GetWebDialogDelegate() const override;

- virtual ui::WebDialogDelegate* GetWebDialogDelegate() override;

- virtual void OnDialogCloseFromWebUI() override;

- virtual void ReleaseWebContentsOnDialogClose() override;

- virtual web_modal::NativeWebContentsModalDialog GetNativeDialog() override;

- virtual content::WebContents* GetWebContents() override;

+ const ui::WebDialogDelegate* GetWebDialogDelegate() const override;

+ ui::WebDialogDelegate* GetWebDialogDelegate() override;

+ void OnDialogCloseFromWebUI() override;

+ void ReleaseWebContentsOnDialogClose() override;

+ web_modal::NativeWebContentsModalDialog GetNativeDialog() override;

+ content::WebContents* GetWebContents() override;

// WebDialogWebContentsDelegate interface.

- virtual void HandleKeyboardEvent(

+ void HandleKeyboardEvent(

content::WebContents* source,

const content::NativeWebKeyboardEvent& event) override;